FieldData to use LongValues in place of NumericDocValues #136469
Merged
+667
−766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Values We don't need doc-by-doc iteration in FieldData, so this simplifies several implementations and also doesn't make unimplemented APIs available.
…Values We don't need doc-by-doc iteration in FieldData, so this simplifies several implementations and also doesn't make unimplemented APIs available.
romseygeek
added
>non-issue
:Analytics/Aggregations
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
This is quite a big PR, but the vast majority of it is mechanical replacement of NumericDocValues with LongValues, and SortedNumericDocValues with SortedNumericLongValues. |
martijnvg
approved these changes
Oct 13, 2025
romseygeek
added
the
auto-merge-without-approval
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Oct 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't use doc-by-doc iteration in FieldData, so this simplifies several
implementations and also doesn't make unimplemented APIs available.
Adds a new SortedNumericLongValues class, analogous to
SortedNumericDoubleValues, which offers a multi-valued version of
LongValues.